Don't extend configuration compileOnly and testCompile from shaded#9579
Merged
eddumelendez merged 3 commits intotestcontainers:mainfrom Feb 18, 2025
patrick-dedication:simplify-shading-configuration-setup
Merged
Don't extend configuration compileOnly and testCompile from shaded#9579eddumelendez merged 3 commits intotestcontainers:mainfrom patrick-dedication:simplify-shading-configuration-setup
eddumelendez merged 3 commits intotestcontainers:mainfrom
patrick-dedication:simplify-shading-configuration-setup
Conversation
* using testCompile has been discouraged since Gradle 3.4 * made sure dependencies on all other configurations are unchanged * no need to change it to testImplementation since testCompileClasspath and testRuntimeClasspath extend from implementation
* compileClasspath already extends from implementation
|
@patrick-dedication asked me to have a look at this. The change looks correct to me as the Extending |
eddumelendez
approved these changes
Feb 18, 2025
Member
|
Thanks for your contribution, @patrick-dedication! and for your comments on @jjohannes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted here I would like to add publishing for the gradle module metadata.
But first I need to get a hang of the setup and maybe even simplify stuff.
Here is a first simplification, the commit descriptions should explain why this is ok, otherwise feel free to ask.
For testCompile see here and here