Rename SA_PASSWORD to MSSQL_SA_PASSWORD as SA_PASSWORD is deprecated#8987
Merged
eddumelendez merged 1 commit intotestcontainers:mainfrom Jul 24, 2024
Merged
Rename SA_PASSWORD to MSSQL_SA_PASSWORD as SA_PASSWORD is deprecated#8987eddumelendez merged 1 commit intotestcontainers:mainfrom
eddumelendez merged 1 commit intotestcontainers:mainfrom
Conversation
Member
|
Thanks for your contribution, @jedla97 ! Do you know if there is a specific version where that env var was added? Just asking in order to see if we can avoid breaking changes to consumers |
Contributor
Author
|
@eddumelendez I didn't find it in release notes, but I run it with 2017 version and it work start fine. As I didn't find 2016 version I can say for sure it will be working there. By https://endoflife.date/mssqlserver the 2016 have only security support. |
Member
|
Thanks, @jedla97 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating
SA_PASSWORDtoMSSQL_SA_PASSWORDasSA_PASSWORDis marked deprecated for some time (I see this note in MSSQL 2017 docs). To see that note you can look here https://learn.microsoft.com/en-us/sql/linux/quickstart-install-connect-docker?view=sql-server-ver16&tabs=cli&pivots=cs1-bash#run-the-container-2