Bigger max aliases used by ParsedDockerComposeFile#8816
Merged
eddumelendez merged 4 commits intotestcontainers:mainfrom Jul 1, 2024
Merged
Bigger max aliases used by ParsedDockerComposeFile#8816eddumelendez merged 4 commits intotestcontainers:mainfrom
eddumelendez merged 4 commits intotestcontainers:mainfrom
Conversation
be26044 to
db52bd0
Compare
Member
|
more than 50 services in a docker compose file? 🤯 |
Contributor
Author
|
:-) It's actually the aliases the problem. So the |
…compose files relying heavily on aliases
db52bd0 to
c26cf1f
Compare
eddumelendez
approved these changes
Jul 1, 2024
Member
|
Thanks for your contribution, @henri-tremblay ! |
lizhou1111
pushed a commit
to lizhou1111/testcontainers-java
that referenced
this pull request
Jul 13, 2024
fokion
pushed a commit
to fokion/testcontainers-java
that referenced
this pull request
Jan 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a docker-compose.yml file start to rely heavily on aliases, we can go above the default maximum of 50. It happened to me. There is no way to override it. We would need to inject LoaderOptions, ParsedDockerComposeFile, DockerComposeFiles and DockerComposeContainer. I don't want to go there.
So instead, I have set a reasonable threshold. I can't see any harm in having it.
This is all in the last commit.
Other commits are fixing things I wanted to improve in a boy scout style.