Exec in container with custom user#7311
Merged
eddumelendez merged 4 commits intotestcontainers:mainfrom Aug 15, 2023
Merged
Conversation
49e0ddd to
89a9f0a
Compare
10 tasks
89a9f0a to
2151f69
Compare
* allows to run commands with a custom user
2151f69 to
d42c942
Compare
eddumelendez
approved these changes
Aug 15, 2023
Member
|
Thanks for your contribution, @megglos ! This will be part of the next release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks,
first of all many thanks for this great library!
We are about the change the default user used in our docker image on https://github.com/camunda/zeebe from root to a less privileged user to better comply with docker security best practices.
Unfortunately we have some test setup code where we'd like to make use of root privileges still though 🙃 . We thus made use of the docker-java-api directly bypassing the
ContainerState.execInContainerAPI offered by you to run commands, which we used previously.Thus we figured it would be nice to expose the
ExecCreateCmd.withUserAPI provided by the docker-java-api on testcontainer's ContainerState.Curious on your feedback on this proposed change!