Use SelinuxContext.SHARED by default#7187
Merged
eddumelendez merged 10 commits intotestcontainers:mainfrom Jun 20, 2023
jeroen-vd-nl:patch-2
Merged
Use SelinuxContext.SHARED by default#7187eddumelendez merged 10 commits intotestcontainers:mainfrom jeroen-vd-nl:patch-2
SelinuxContext.SHARED by default#7187eddumelendez merged 10 commits intotestcontainers:mainfrom
jeroen-vd-nl:patch-2
Conversation
On systems with SElinux enforcing trying to bind a filesystem path without a context will result in an error. Using shared context by default will make `withFileSystemBind(String hostPath, String containerPath)` method work for all systems. On Windows, Mac OS and Linux systems without SElinux it will have no effect. On systems with SElinux enforcing it will make the path accessible to the container. Signed-off-by: monosoul <Kloz.Klaud@gmail.com>
Contributor
Author
|
Update from our side: we can achieve the same result by using the local compose. Still this might be an addition to the code base, but for us the added value has vanished. Maybe for @monosul it still adds value. |
SelinuxContext.SHARED by default
Member
|
Thanks @jeroen-vd-nl ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup on #6294
Commits in total: