Add TestcontainersHostPropertyClientStrategy#7053
Merged
eddumelendez merged 7 commits intomainfrom May 26, 2023
Merged
Conversation
Use `tc.host` in `~/.testcontainers.properties` to try and connect to docker.
Contributor
HofmeisterAn
left a comment
There was a problem hiding this comment.
I just had a quick look, it does not cover
This strategy must ensure that user-defined variables such as
DOCKER_HOST,TESTCONTAINERS_HOST_OVERRIDEandTESTCONTAINERS_DOCKER_SOCKET_OVERRIDEdo not have an effect.
mentioned in the RFC (specific TESTCONTAINERS_HOST_OVERRIDE and TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE), or does it?
kiview
previously approved these changes
May 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New strategy to use
tc.hostin~/.testcontainers.propertiesto try and connectto docker.
This strategy ensure that user-defined variables such as
DOCKER_HOST,TESTCONTAINERS_HOST_OVERRIDEandTESTCONTAINERS_DOCKER_SOCKET_OVERRIDEdo not have an effect.This strategy takes precedence over other strategies.