Add new section for test integrations#6930
Merged
eddumelendez merged 8 commits intotestcontainers:mainfrom Apr 21, 2023
LeoColman:main
Merged
Add new section for test integrations#6930eddumelendez merged 8 commits intotestcontainers:mainfrom LeoColman:main
eddumelendez merged 8 commits intotestcontainers:mainfrom
LeoColman:main
Conversation
eddumelendez
requested changes
Apr 19, 2023
Member
eddumelendez
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I've left some comments
Co-authored-by: Eddú Meléndez Gonzales <eddu.melendez@gmail.com>
Co-authored-by: Eddú Meléndez Gonzales <eddu.melendez@gmail.com>
Contributor
Author
|
Done :) |
Member
|
Hi @LeoColman, thinking more about this... I think we should not duplicate the existing documentation in kotest but we should point to it. what do you think about renaming the file to integration and then add Kotest with a link to https://kotest.io/docs/extensions/test_containers.html The content can says something like |
Contributor
Author
|
I agree!
I even tried to make it smaller to avoid maintenance issues.
How could I apply your suggestion?
Apr 20, 2023 19:46:14 Eddú Meléndez Gonzales ***@***.***>:
…
Hi @LeoColman[https://github.com/LeoColman], thinking more about this... I think we should not duplicate the existing documentation in kotest but we should point to it. what do you think about renaming the file to integration and then add Kotest with a link to https://kotest.io/docs/extensions/test_containers.html
The content can says something like *The following open source projects use Testcontainers*
—
Reply to this email directly, view it on GitHub[#6930 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAMBCI7FIZCNKMDDT3MKGLLXCHDEDANCNFSM6AAAAAAXEV2VXY].
You are receiving this because you were mentioned.[Tracking image][https://github.com/notifications/beacon/AAMBCI6NH45AMXKBGEDNKN3XCHDEDA5CNFSM6AAAAAAXEV2VX2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS2NSL26.gif]
|
Member
|
Just update this PR :) |
Contributor
Author
Contributor
Author
|
I thought of adding a |
eddumelendez
approved these changes
Apr 21, 2023
Member
|
Thanks for your contribution, @LeoColman ! This will be available soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds documentation on how Testcontainers can be integrated with the Kotest framework.
From the very old #2533 it was decided that a reference to Kotest would be great in the docs. This commit adds it.