Use the current thread's classloader for classes#6926
Merged
eddumelendez merged 2 commits intotestcontainers:mainfrom Apr 26, 2023
Merged
Conversation
Switch from using the caller's classloader to using the current thread's classloader. This will fix testcontainers#6923 and quarkusio/quarkus#32627 Please enter the commit message for your changes. Lines starting
100415e to
baea4a1
Compare
eddumelendez
approved these changes
Apr 26, 2023
Contributor
Author
|
@eddumelendez do I need to keep merging in from |
Member
|
I'm just waiting for the last check to pass and I will merge it. |
Member
|
Thanks for your contribution, @snowe2010 ! This is now in |
Contributor
Author
|
Wooh! Thank you so much! Glad I could help! |
Member
|
@snowe2010 this fix is part of 1.18.1 |
Contributor
Author
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from using the caller's classloader to using the current thread's
classloader. Using the caller's classloader results in subtle issues where
if a test is spawned on a different thread, you will not be able to find
the Substitutor, even though it is present.
This will fix
#6923 and
quarkusio/quarkus#32627