Support visiting repeated Payload#216
Merged
yuandrew merged 3 commits intotemporalio:masterfrom Apr 9, 2025
Merged
Conversation
cretz
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added support for repeated payload.
Also added a note in the
VisitPayloadsgodoc mentioning how we don't support directly visiting payloads (see #202 (comment) for context).Closes temporalio/sdk-go#1865 and can probably close temporalio/sdk-go#1862 as well, now that the godoc mentions this scenario.
Why?
Support an edge case scenario, only AggregationGroup today uses this.
How did you test it?
Added tests
Potential risks