Conversation
tdeebswihart
approved these changes
Jan 23, 2025
Contributor
tdeebswihart
left a comment
There was a problem hiding this comment.
The diff stats are horrifying for this change. Thank you for following this saga through to its conclusion!
cretz
approved these changes
Jan 23, 2025
Contributor
cretz
left a comment
There was a problem hiding this comment.
Echoing @tdeebswihart, thank you very much for sticking with it
yiminc
approved these changes
Jan 24, 2025
bergundy
approved these changes
Jan 24, 2025
Shivs11
pushed a commit
that referenced
this pull request
Jan 25, 2025
**What changed?** Remove the hack to allow disabling UTF-8 validation on our Go protos. **Why?** We should allow protobuf to validate all strings are valid UTF-8 as specified. **How did you test it?** Will be tested by server, sdk, and other components. **Potential risks** Anyone still using invalid UTF-8 will see their grpc requests fail. We've been monitoring for this in Temporal Cloud for most of a year now and there's no more invalid data. Self-hosted users should do the same validation before upgrading to a server or Go SDK release that contains this change (instructions [here](https://github.com/temporalio/temporal/releases/tag/v1.24.0)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Remove the hack to allow disabling UTF-8 validation on our Go protos.
Why?
We should allow protobuf to validate all strings are valid UTF-8 as specified.
How did you test it?
Will be tested by server, sdk, and other components.
Potential risks
Anyone still using invalid UTF-8 will see their grpc requests fail. We've been monitoring for this in Temporal Cloud for most of a year now and there's no more invalid data. Self-hosted users should do the same validation before upgrading to a server or Go SDK release that contains this change (instructions here).