Merged
Conversation
amrbashir
requested changes
May 30, 2024
Member
amrbashir
left a comment
There was a problem hiding this comment.
Thanks for your contributions, left a few questions and nitpicks
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
change thiserror crate version to 1.0 Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
AtifChy
commented
May 30, 2024
Author
AtifChy
left a comment
There was a problem hiding this comment.
I made all the necessary changes
amrbashir
reviewed
May 30, 2024
amrbashir
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously it was very tedious to handle errors, i simplified the process by using
thiserrorcrate.