Skip to content

prevent uncomment collision in 1.x invoke_key templating (fix #10084)#10087

Merged
amrbashir merged 2 commits into1.xfrom
fix/1.x-invoke-key-comments
Jun 18, 2024
Merged

prevent uncomment collision in 1.x invoke_key templating (fix #10084)#10087
amrbashir merged 2 commits into1.xfrom
fix/1.x-invoke-key-comments

Conversation

@chippers
Copy link
Copy Markdown
Member

@chippers chippers self-assigned this Jun 18, 2024
@chippers chippers requested a review from a team as a code owner June 18, 2024 15:07
@chippers chippers changed the title prevent uncomment collision in invoke_key templating prevent uncomment collision in 1.x invoke_key templating (fix #10084) Jun 18, 2024
@chippers
Copy link
Copy Markdown
Member Author

@amrbashir this should probably merit a patch release

@amrbashir amrbashir merged commit c2d3afa into 1.x Jun 18, 2024
@amrbashir amrbashir deleted the fix/1.x-invoke-key-comments branch June 18, 2024 16:42
@amrbashir
Copy link
Copy Markdown
Member

amrbashir commented Jun 18, 2024

I am away on holiday this week and probably won't be able to fix MSRV CI and publish but feel free to do so if you wish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants