fix(query-sync-storage-persister): Relax undefined check against storage to handle null values #5095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 89dc2b2:
|
Collaborator
|
@nfm doesn't the async persister have the same guard? |
Contributor
Author
Fixes TanStack#4957. On Android WebView if `setDomStorageEnabled` is not configured, `window.localStorage` will be `null` (rather than `undefined`). Relax the existing conditional to check if `storage` is present to handle both `null` and `undefined` values to remove a gotcha here.
f6f21b6 to
620e3b4
Compare
Contributor
Author
|
It looks like this failed a test but I'm not sure why - from what I can gather it looks unrelated: Please let me know if I've done something silly here 🙃 |
TkDodo
approved these changes
Mar 17, 2023
…android-webview-if-setdomstorageenabled-is-not-configured
Collaborator
|
just our standard test flakiness ... working on it 😅 |
TkDodo
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4957.
On Android WebView if
setDomStorageEnabledis not configured,window.localStoragewill benull(rather thanundefined).Relax the existing conditional to check if
storageis present to handle bothnullandundefinedvalues to remove a gotcha here.