Do not sort and format stylesheets that didn't change#17824
Merged
RobinMalfait merged 4 commits intomainfrom Apr 29, 2025
Merged
Do not sort and format stylesheets that didn't change#17824RobinMalfait merged 4 commits intomainfrom
RobinMalfait merged 4 commits intomainfrom
Conversation
547a840 to
f07a609
Compare
thecrypticace
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the upgrade tooling at tiny bit to make sure that as long as we didn't change any of the stylesheets, that we also don't sort internal nodes and/or format the stylesheet at all.
This is important in case the Prettier rules are different or if a totally different formatter is used.
Essentially, if we didn't have to change the stylesheets because of a migration, we don't want to change it due to a formatter either.