Skip color-mix(…) when opacity is 100%#17815
Merged
RobinMalfait merged 4 commits intomainfrom Apr 28, 2025
Merged
Conversation
|
|
||
| describe('custom utilities', () => { | ||
| test('custom static utility', async () => { | ||
| let { build } = await compile(css` |
Contributor
There was a problem hiding this comment.
These format changes seem weird
Contributor
There was a problem hiding this comment.
Did Prettier update and change this or something?
Member
Author
There was a problem hiding this comment.
I was too quick to quit vim and prettier didn't run in time 😂
4079e70 to
c788f42
Compare
thecrypticace
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves colors with alpha values where the alpha value results in 100%.
Before this change, a class like
bg-red-500/100would be generated as:But we don't need the
color-mix, or the fallback styles at all in case the alpha value is 100%.After this change the
bg-red-500/100class will generate as:Which is essentially the same as
bg-red-500, but we can migrate that away in the future. At least the generated CSS is smaller.Test plan