Inject polyfills after @import and body-less @layer#17493
Merged
RobinMalfait merged 5 commits intomainfrom Apr 2, 2025
Merged
Conversation
9a93293 to
e50e91b
Compare
e50e91b to
66090e8
Compare
These snapshots look a bit confusing, but Lightning CSS is optimizing the body-less `@layer` and moving things around a bit.
philipp-spiess
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where polyfills were injected at the top, but they should be after
@importand body-less@layerrules.This is necessary in case you are using Google fonts like this for example:
While the
@import url(…);sits above@import "tailwindcss";in the final generated CSS we injected the polyfills at the very beginning.This PR will inject the polyfills after the first AST Node that is not:
@import url(…)@layer foo, bar, baz;The snapshots look a little confusing, but that's because Lightning CSS is optimizing the output and moving things around a bit:
Lightning CSS Playground
Fixes: #17494