Disable padding in @source inline(…) brace expansion#17491
Merged
philipp-spiess merged 1 commit intomainfrom Apr 1, 2025
Merged
Disable padding in @source inline(…) brace expansion#17491philipp-spiess merged 1 commit intomainfrom
@source inline(…) brace expansion#17491philipp-spiess merged 1 commit intomainfrom
Conversation
9a41b7a to
d0d56ea
Compare
thecrypticace
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17492
The padding code we had was incorrect as it would always pad on the largest string representation. So for an input like this:
It would create the following candidates:
z-010z-020z-030z-040z-050z-060z-070z-060z-070z-100Instead of fixing the padding logic we realized that Tailwind utilities don't need padding at all so this PR removes this feature
Test plan
@source inline("z-{10..100..10}");