Merged
Conversation
84c72ca to
52a7f0f
Compare
|
@philipp-spiess I think you might have used an old play link, which is my bad. I updated the link in trello but not in discord. (New link) I readjusted the scale so it goes from |
Contributor
Author
|
@danhollick Ah great spot, updated it and also ran your play through a Vite project to make sure it's creating the right CSS: https://tailwind-text-shadows-preview-2kdnjb32b.vercel.app/ |
Member
|
@philipp-spiess Can we add UI tests for this one to make sure the shadow colors work? Like the box-shadow utilities we have to not really use the variables here annoyingly for the colors to work, so if we ever forget that and try to refactor it to use variables it would be good to have tests that fail. |
RobinMalfait
approved these changes
Mar 28, 2025
This was referenced Apr 5, 2025
philipp-spiess
pushed a commit
to tailwindlabs/tailwindcss.com
that referenced
this pull request
Apr 14, 2025
`shadow-<color>` is used for box-shadow, the right name is `text-shadow-<color>` according to tailwindlabs/tailwindcss#17389.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new
text-shadow-*utilities and default values courtesy of @danhollick's.Usage is similar to the normal
shadow-*utilities, for example:Since this PR also adds first-class support for the
--text-shadowtheme namespace, it also means it resolves #17047.Test plan
vitesetup and ran a production build to ensure it looks correct: https://tailwind-text-shadows-preview-2kdnjb32b.vercel.app/