Fix class extraction followed by ( in Pug#17320
Merged
RobinMalfait merged 4 commits intomainfrom Mar 21, 2025
Merged
Conversation
Because `(` is replaced with a ` ` we extract a few more candidates.
thecrypticace
approved these changes
Mar 21, 2025
Merged
philipp-spiess
added a commit
that referenced
this pull request
Mar 24, 2025
This change was added in #17320 which was not released yet, see commit order on `main`: https://github.com/tailwindlabs/tailwindcss/commits/main/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a class shorthand in Pug followed by a
(is not properly extracted.The
text-sky-600is extracted, but thebg-neutral-900is not.Fixes: #17313
Test plan
We had this exact same bug in Slim (#17278). Since Pug, Slim and Haml are the only pre processors we have right now with this dot-separated class notation I also double checked the Haml pre-processor if this is an issue or not (and it's already covered there).