Fix variants with <digit>.</digit> are extracted correctly#17153
Merged
RobinMalfait merged 5 commits intomainfrom Mar 12, 2025
Merged
Fix variants with <digit>.</digit> are extracted correctly#17153RobinMalfait merged 5 commits intomainfrom
<digit>.</digit> are extracted correctly#17153RobinMalfait merged 5 commits intomainfrom
Conversation
This applies the same logic as the named utility machine
adamwathan
reviewed
Mar 12, 2025
thecrypticace
approved these changes
Mar 12, 2025
Contributor
thecrypticace
left a comment
There was a problem hiding this comment.
lgtm (aside from the comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where if you use a number with a decimal in a variant then it wasn't picked up correctly.
E.g.:
This PR fixes that behavior by applying the same rules for utilities where a
.is valid if it is surrounded by numbers.Test plan
They are crossed out just because it's not a default value we know in the system, but you can see that the
1.part is also extracted now.Fixes: #17148