Skip to content

Ensure classes between > and < are properly extracted#17094

Merged
RobinMalfait merged 3 commits intomainfrom
fix/issue-17088
Mar 10, 2025
Merged

Ensure classes between > and < are properly extracted#17094
RobinMalfait merged 3 commits intomainfrom
fix/issue-17088

Conversation

@RobinMalfait
Copy link
Copy Markdown
Member

@RobinMalfait RobinMalfait commented Mar 9, 2025

This PR fixes an issue where candidates inside >…< were not always correctly extracted. This happens in XML-like languages where the classes are inside of these boundaries.

E.g.:

<!-- Fluid template language -->
<f:variable name="bgStyle">
  <f:switch expression="{data.layout}">
    <f:case value="0">from-blue-900 to-cyan-200</f:case>
    <!--              ^^^^^^^^^^^^^^^^^^^^^^^^^      -->
    <f:case value="1">from-cyan-600 to-teal-200</f:case>
    <f:defaultCase>from-blue-300 to-cyan-100</f:defaultCase>
  </f:switch>
</f:variable>

Fixes: #17088

Test plan

  1. Added a new test
  2. Existing tests pass

@RobinMalfait RobinMalfait requested a review from a team as a code owner March 9, 2025 19:19
@RobinMalfait RobinMalfait merged commit bc5a8c3 into main Mar 10, 2025
5 checks passed
@RobinMalfait RobinMalfait deleted the fix/issue-17088 branch March 10, 2025 10:28
@RobinMalfait RobinMalfait mentioned this pull request Mar 10, 2025
Closed
@fossabot fossabot bot mentioned this pull request Oct 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@philipp-spiess philipp-spiess philipp-spiess approved these changes

@thecrypticace thecrypticace thecrypticace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Classes not generated after upgrading npm packages when CSS classes are inside TYPO3 Fluid template tags

3 participants

@RobinMalfait @philipp-spiess @thecrypticace