Treat starting single quote as verbatim text in Slim#17085
Merged
RobinMalfait merged 3 commits intomainfrom Mar 10, 2025
Merged
Treat starting single quote as verbatim text in Slim#17085RobinMalfait merged 3 commits intomainfrom
RobinMalfait merged 3 commits intomainfrom
Conversation
philipp-spiess
approved these changes
Mar 10, 2025
Contributor
philipp-spiess
left a comment
There was a problem hiding this comment.
I wonder if our pre-processor logic should also only process stuff per-line so we avoid this kind of behavior? 🤔
Member
Author
|
@philipp-spiess I was thinking about that as well, but it makes it potentially harder for other checks where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in Slim templates where a single quote
'at the start of the line (excluding white space) is considered a line indicator for verbatim text. It is not considered a string in this scenario.So something like this:
div 'Foo'Will compile to:
Fixes: #17081