Ensure classes containing number followed by dash or underscore are extracted correctly#16980
Merged
RobinMalfait merged 4 commits intotailwindlabs:mainfrom Mar 6, 2025
woohm402:patch-1
Merged
Ensure classes containing number followed by dash or underscore are extracted correctly#16980RobinMalfait merged 4 commits intotailwindlabs:mainfrom woohm402:patch-1
RobinMalfait merged 4 commits intotailwindlabs:mainfrom
woohm402:patch-1
Conversation
philipp-spiess
approved these changes
Mar 6, 2025
Contributor
philipp-spiess
left a comment
There was a problem hiding this comment.
Awesome! I'm really thrilled that you contributed, we've made some big changes in this code part recently and there is no dice someone would have had the courage to contribute before the changes. Great stuff!
Contributor
Author
|
Thank you for the quick review! I’m really glad to contribute 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16978, and also added support for dash.
Classes like
text-theme1-primaryortext-theme1_primaryshould be treated as valid.If this approach is not aligned with the project’s direction or there are any concerns, please feel free to close or edit this PR 😃
As is
Classes conatining number followed by dash or underscore (e.g.
bg-theme1-primary,text-title1_strong) are ignored, and utility classes are not generated.To be
Classes conatining number followed by dash or underscore (e.g.
bg-theme1-primary,text-title1_strong) are treated as valid tailwindcss classes