Statically link Visual Studio redistributables on Windows builds#16602
Merged
philipp-spiess merged 8 commits intomainfrom Feb 18, 2025
Merged
Statically link Visual Studio redistributables on Windows builds#16602philipp-spiess merged 8 commits intomainfrom
philipp-spiess merged 8 commits intomainfrom
Conversation
Contributor
Author
|
RobinMalfait
approved these changes
Feb 18, 2025
Member
RobinMalfait
left a comment
There was a problem hiding this comment.
Not 100% sure how to test this, but relying on CI builds makes sense 💪
Actually, I wonder why it works on CI and not in some environments from our users 🤔
Contributor
Author
|
@RobinMalfait I suspect the CI runners have MSVC redistributables installed 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR statically links the C runtime on Windows builds so we no longer require installing Visual Studio redistributables.
Test plan
Relying on CI here to not break anything for Windows.