Ensure @custom-variant foo () has a non-empty selector list #16009
Merged
RobinMalfait merged 3 commits intomainfrom Jan 29, 2025
Merged
Ensure @custom-variant foo () has a non-empty selector list #16009RobinMalfait merged 3 commits intomainfrom
@custom-variant foo () has a non-empty selector list #16009RobinMalfait merged 3 commits intomainfrom
Conversation
philipp-spiess
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where an empty selector list was valid when defining a
@custom-variant.Given this input:
@custom-variant foo ();If you then use it with a utility such as
foo:flex, then the following (incorrect) CSS was generated:Which is invalid CSS. This PR will now validate that that we have at least something and show an error accordingly.