Ensure CSS variable shorthand uses valid CSS variables#15738
Merged
RobinMalfait merged 5 commits intonextfrom Jan 27, 2025
Merged
Ensure CSS variable shorthand uses valid CSS variables#15738RobinMalfait merged 5 commits intonextfrom
RobinMalfait merged 5 commits intonextfrom
Conversation
|
|
||
| expect(run('bg-(color:my-color)', { utilities })).toMatchInlineSnapshot(`[]`) | ||
| }) | ||
|
|
Contributor
There was a problem hiding this comment.
We should add tests for stuff like bg-foo/(bar) to make sure it's thrown out too
Just another test to verify
thecrypticace
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where we didn't always correctly validated invalid CSS variables when using the CSS variable shorthand syntax.
This PR fixes that by ensuring we start with
--. We can't validate that the variable exists at runtime, but we can validate if it looks like a valid CSS variable.We can go a step further by validating if the CSS variable is valid syntax (e.g.: all characters are valid), but we can introduce this if this is causing actual issues in projects.
Used to compile to:
But not anymore.