Skip to content

fix: update lilconfig for ESM and Windows support#15289

Merged
thecrypticace merged 2 commits intotailwindlabs:mainfrom
shellscape:main
Dec 3, 2024
Merged

fix: update lilconfig for ESM and Windows support#15289
thecrypticace merged 2 commits intotailwindlabs:mainfrom
shellscape:main

Conversation

@shellscape
Copy link

This PR updates lilconfig from v2.1.0 to v3.1.3. Significant improvements to this package include Windows absolute path support as well as ESM config files support. This supersedes #14029 which has fallen behind and has conflicts with the upstream branch. This is a critical update for Next.js apps running in development which have dependencies on packages that use an updated version of lilconfig. I understand that v4 will not be using lilconfig but it's an important update for users on v3.x in the meantime.

@shellscape shellscape requested a review from a team as a code owner December 3, 2024 18:50
@thecrypticace thecrypticace self-assigned this Dec 3, 2024
@thecrypticace
Copy link
Contributor

We only use lilconfig in the CLI. How would this affect Next.js apps using PostCSS directly?

@thecrypticace
Copy link
Contributor

(gonna get this updated regardless — just wondering)

@shellscape
Copy link
Author

Triage for this issue shellscape/jsx-email#257 concluded that next.js/webpack was eagerly bundling 2.1.0 as the predominant lilconfig version and was not bundling both 2.1.0 and 3.1.2 (from jsx-email) during development. That resulted in errors when users attempted to use a jsx-email config file in the same app that included tailwind. I was able to reproduce that in fresh next.js apps consistently, and was able to workaround by forcing pnpm/npm to install 3.1.2 only via overrides. Super weird case where webpack is misbehaving in this context. I didn't get a chance to triage what in next.js is causing the bundling issue in dev, but that's next on my list.

Thank you very much for tackling this so quickly.

@thecrypticace
Copy link
Contributor

Got it. Seems like a Next.js bug there but yeah we should update. Sorry for letting this sit out so long.

@thecrypticace thecrypticace merged commit 8c8c986 into tailwindlabs:main Dec 3, 2024
@thecrypticace
Copy link
Contributor

Will get a new v3 release out today 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants