Add variable fallback to fix Chrome issue#15003
Merged
thecrypticace merged 4 commits intomainfrom Nov 14, 2024
Merged
Conversation
d655fcd to
cdcab04
Compare
adamwathan
reviewed
Nov 14, 2024
adamwathan
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around an issue in Chrome where
::selectiondoes not read from variables defined on::selectionthus breaking all uses of color utilities with the selection variant. e.g.selection::bg-red-200.We now add a fallback value of
1to all uses ofvar(--tw-bg-opacity),var(--tw-text-opacity),var(--tw-border-opacity), etc… since Chrome treats the variable as if it did not exist because it's not defined on the parent.In Chrome 131 (until the change is rolled back) existing utilities like these will not work:
selection:text-opacity-50selection:[--tw-text-opacity:0.5]Fixes #15000