Set GITHUB_TOKEN for cargo-binstall by default#556
Conversation
NobodyXu
left a comment
There was a problem hiding this comment.
Thank you!
I've been reluctant to do this because of the implicit github-token passing.
I think we should put up documentation on this and someway to disable it?
Well, that's what the actions/checkout does, but it might indeed not be a good idea here. |
|
I will try to improve on cargo-binstall behavior, ideally users should not have to pass the github token, unless they are really installing a lot of crates or the crate itself doesn't provide any information in manifest and binstall has to figure out itself. I think we can at least speed it up and avoid the need of token, for crate providing package.binstall with pkg-url |
|
cc @taiki-e I have resolved the merge conflicts, can we merge this in and have another release please? |
#554 (comment)
cc @NobodyXu
Closes #561