Skip to content

Set GITHUB_TOKEN for cargo-binstall by default#556

Merged
taiki-e merged 2 commits intomainfrom
dev-binstall-token
Dec 4, 2024
Merged

Set GITHUB_TOKEN for cargo-binstall by default#556
taiki-e merged 2 commits intomainfrom
dev-binstall-token

Conversation

@taiki-e
Copy link
Owner

@taiki-e taiki-e commented Jun 22, 2024

#554 (comment)

The fact that cargo-binstall's performance or robustness would be worse without this env var at a high probability is very unfortunate.

cc @NobodyXu

Closes #561

Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I've been reluctant to do this because of the implicit github-token passing.

I think we should put up documentation on this and someway to disable it?

@taiki-e
Copy link
Owner Author

taiki-e commented Jun 22, 2024

the implicit github-token passing

Well, that's what the actions/checkout does, but it might indeed not be a good idea here.

@taiki-e taiki-e closed this Jun 22, 2024
@taiki-e taiki-e deleted the dev-binstall-token branch June 22, 2024 03:51
@NobodyXu
Copy link
Collaborator

I will try to improve on cargo-binstall behavior, ideally users should not have to pass the github token, unless they are really installing a lot of crates or the crate itself doesn't provide any information in manifest and binstall has to figure out itself.

I think we can at least speed it up and avoid the need of token, for crate providing package.binstall with pkg-url

@taiki-e taiki-e restored the dev-binstall-token branch November 11, 2024 17:32
@taiki-e taiki-e reopened this Nov 11, 2024
NobodyXu
NobodyXu previously approved these changes Nov 11, 2024
@NobodyXu
Copy link
Collaborator

NobodyXu commented Dec 4, 2024

cc @taiki-e I have resolved the merge conflicts, can we merge this in and have another release please?

@taiki-e taiki-e merged commit 0139dfd into main Dec 4, 2024
@taiki-e taiki-e deleted the dev-binstall-token branch December 4, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pass GITHUB_TOKEN for cargo binstall for per-ip rate limit

2 participants