Skip to content

update jaq asset name format#1861

Merged
taiki-e merged 2 commits into
taiki-e:mainfrom
MusicalNinjaDad:main
May 22, 2026
Merged

update jaq asset name format#1861
taiki-e merged 2 commits into
taiki-e:mainfrom
MusicalNinjaDad:main

Conversation

@MusicalNinjaDad

Copy link
Copy Markdown
Contributor

was changed in v2.0.0

fixes 01mf02/jaq#435

taiki-e
taiki-e previously approved these changes May 21, 2026

@taiki-e taiki-e left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MusicalNinjaDad

Copy link
Copy Markdown
Contributor Author

This seems to be failing for unrelated reasons. But if there is anything I should do, please let me know.

Comment thread tools/codegen/base/jaq.json Outdated
Comment thread tools/codegen/base/jaq.json Outdated
@taiki-e

taiki-e commented May 22, 2026

Copy link
Copy Markdown
Owner

CI failures are unrelated and can be fixed by rebase or merge main branch.
(If you allow the maintainer to edit the PR, we can handle it on our end.)

@MusicalNinjaDad

Copy link
Copy Markdown
Contributor Author

All sorted now and thanks for the suggestion on supporting both naming conventions

@taiki-e taiki-e merged commit 1649307 into taiki-e:main May 22, 2026
79 checks passed
@taiki-e

taiki-e commented May 22, 2026

Copy link
Copy Markdown
Owner

Published in 2.79.5.

@MusicalNinjaDad

Copy link
Copy Markdown
Contributor Author

Thanks. My job to parse a common yaml matrix from an external file went from 22s to 7s. 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

taiki-e/install-action blocked at v1.6.0

2 participants