Skip to content

Support cargo-apple-runner#1731

Merged
taiki-e merged 2 commits into
taiki-e:mainfrom
madsmtm:add-cargo-apple-runner
May 4, 2026
Merged

Support cargo-apple-runner#1731
taiki-e merged 2 commits into
taiki-e:mainfrom
madsmtm:add-cargo-apple-runner

Conversation

@madsmtm

@madsmtm madsmtm commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

https://github.com/madsmtm/cargo-apple-runner, it's a Cargo runner I'm developing for making it easy to run cargo test --target aarch64-apple-ios-sim, which is especially useful in CI.

@madsmtm madsmtm force-pushed the add-cargo-apple-runner branch from 64568f0 to b0411bf Compare April 19, 2026 21:31
@madsmtm

madsmtm commented Apr 19, 2026

Copy link
Copy Markdown
Contributor Author

Hmm, while I could publish precompiled GH releases for Linux too, this tool currently only really makes sense on macOS.

Your CI seems to have trouble with that though, do you have a suggestion for how to fix that?

@madsmtm madsmtm marked this pull request as ready for review April 19, 2026 21:46
@taiki-e

taiki-e commented Apr 20, 2026

Copy link
Copy Markdown
Owner

Thanks for the PR!

The CI issue is caused by our test script assuming that everything is available on x86_64_linux, so I think it should be fixed by removing [[ "${host_arch}" != "x86_64" ]] && in the following line.

install-action/tools/ci/tool-list.sh

Line 151 in 6c30010

if [[ "${host_arch}" != "x86_64" ]] && [[ "$(jq -r --arg p "${host_arch}_${host_os}_gnu" '.platform[$p]' "${manifest}")" == "null" ]] && [[ "$(jq -r --arg p "${host_arch}_${host_os}_musl" '.platform[$p]' "${manifest}")" == "null" ]]; then

@madsmtm madsmtm closed this Apr 20, 2026
@madsmtm madsmtm reopened this Apr 20, 2026
@madsmtm madsmtm force-pushed the add-cargo-apple-runner branch 2 times, most recently from d72f01a to 601713b Compare April 20, 2026 18:20
@madsmtm

madsmtm commented Apr 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hmm, that seems to error with:

tools/ci/tool-list.sh: line 151: jq: command not found

I added an explicit check for cargo-apple-runner for now, but later on you might want to fix it by installing jq earlier (instead of in main.sh)?

@madsmtm madsmtm force-pushed the add-cargo-apple-runner branch from 601713b to 31340e2 Compare April 23, 2026 00:33
taiki-e
taiki-e approved these changes May 4, 2026
View reviewed changes

@taiki-e taiki-e left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit ff1c16d into taiki-e:main May 4, 2026
84 checks passed
@taiki-e

taiki-e commented May 4, 2026

Copy link
Copy Markdown
Owner

Published in v2.76.0.

@madsmtm madsmtm deleted the add-cargo-apple-runner branch May 4, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taiki-e taiki-e taiki-e approved these changes

+1 more reviewer

@scutuatua-crypto scutuatua-crypto scutuatua-crypto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@madsmtm @taiki-e @scutuatua-crypto