[Console] Preserve --help option when a command is not found#62627
Conversation
632e02c to
8696efc
Compare
|
In a shorter way: if ($this->wantHelps) {
$this->wantHelps = false;
$helpCommand = $this->get('help');
$helpCommand->setCommand($command);
+ $this->wantHelps = true;
return $helpCommand;
} |
|
You added tests, but even without changing |
7dcead4 to
985b75e
Compare
|
Hi @Maxcastel, thank you so much for your feedback 😄
You're right, the
I'm not sure about that change 🤔 |
I modified the test Thanks again for your feedback :) |
|
I didn’t run the right tests 😅 Sorry @santysisi for the inconvenience. |
985b75e to
e240a69
Compare
e240a69 to
ac79f5b
Compare
|
Thank you @santysisi. |
This PR resolves 3 issues:
--helpis not preserved when a command is not found--helpoption is present and the original command is not found.