[Feature] Add options expansion to Add Lines Configuration#990
Merged
fabpot merged 1 commit intosymfony:1.xfrom Feb 5, 2024
Merged
Conversation
1146790 to
bc440ea
Compare
alamirault
reviewed
Oct 26, 2023
alamirault
approved these changes
Oct 27, 2023
maxhelias
approved these changes
Nov 20, 2023
Member
|
Thanks for the PR. Can you please rebase it for branch 1.x? Please also revert the CS changes while doing so as 1.x still supports PHP 7.1 |
042764b to
915e44f
Compare
Contributor
Author
|
Thanks for the suggestion! Questions:
The earliest occurance I found of this failure is here: https://github.com/symfony/flex/actions/runs/7101907556/job/19331086614 I've tried debugging this, but TBH I don't even know where to start (and when running the tests locally I had a different error) - do you have any suggestions where to look? |
nicolas-grekas
approved these changes
Feb 5, 2024
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
Nervemind the failures, they're false-positives.
023c975 to
644e426
Compare
Member
|
Thank you @mnocon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I've got a chance to play with the new AddLines configurator and it's an extremely useful feature, thanks for introducing it!
There is one small thing that seems missing to me: support for placeholders that are available in the
copy-from-packageandcopy-from-recipeconfigurators.It's this feature:
(this text comes from https://github.com/symfony/recipes)
This small PR makes it possible to use placeholders in the add-lines configurator.
I'm not sure about the target branch, please let me know if I should rebase to 1.x - also not sure if I should mention it in the doc somewhere.