fix: propagate tsc errors (#82)

privatenumber · web-flow · commit ff295cab68bd · 2025-08-14T10:44:47.000+08:00
diff --git a/src/resolver.ts b/src/resolver.ts
@@ -84,7 +84,9 @@ export function createDtsResolvePlugin({
             const isRelativeOrAbsolute =
               id.startsWith('.') || path.isAbsolute(id)
             if (isRelativeOrAbsolute) {
-              return this.error(`Cannot resolve import '${id}' from '${importer}'`)
+              return this.error(
+                `Cannot resolve import '${id}' from '${importer}'`,
+              )
             }
             return external
           }
diff --git a/src/tsc/index.ts b/src/tsc/index.ts
@@ -336,8 +336,19 @@ export function tscEmit(tscOptions: TscOptions): TscResult {
     // @ts-expect-error private API: forceDtsEmit
     true,
   )
-  if (emitSkipped && diagnostics.length) {
-    return { error: ts.formatDiagnostics(diagnostics, formatHost) }
+  const emitErrors = diagnostics.filter(
+    (d: ts.Diagnostic) => d.category === ts.DiagnosticCategory.Error,
+  )
+  if (emitErrors.length > 0) {
+    return { error: ts.formatDiagnostics(emitErrors, formatHost) }
+  }
+  if (emitSkipped) {
+    const errors = ts
+      .getPreEmitDiagnostics(program)
+      .filter((d: ts.Diagnostic) => d.category === ts.DiagnosticCategory.Error)
+    if (errors.length > 0) {
+      return { error: ts.formatDiagnostics(errors, formatHost) }
+    }
   }
 
   // If TypeScript skipped emitting because the file is already a .d.ts (e.g. a
diff --git a/tests/fixtures/type-error.ts b/tests/fixtures/type-error.ts
@@ -0,0 +1 @@
+export const n: number = 'string'
diff --git a/tests/tsc.test.ts b/tests/tsc.test.ts
@@ -17,6 +17,8 @@ describe('tsc', () => {
         dts({
           emitDtsOnly: true,
           compilerOptions: {
+            module: 'preserve',
+            moduleResolution: 'bundler',
             skipLibCheck: true,
             isolatedDeclarations: false,
           },
@@ -33,7 +35,11 @@ describe('tsc', () => {
       [
         dts({
           emitDtsOnly: true,
-          compilerOptions: { isolatedDeclarations: false },
+          compilerOptions: {
+            module: 'preserve',
+            moduleResolution: 'bundler',
+            isolatedDeclarations: false,
+          },
         }),
       ],
     )
@@ -132,6 +138,9 @@ describe('tsc', () => {
       dts({
         emitDtsOnly: true,
         vue: true,
+        compilerOptions: {
+          isolatedDeclarations: false,
+        },
       }),
     ])
     expect(snapshot).toMatchSnapshot()
@@ -167,4 +176,14 @@ describe('tsc', () => {
     ])
     expect(snapshot).toMatchSnapshot()
   })
+
+  test('fail on type errors', async () => {
+    await expect(() =>
+      rolldownBuild(path.resolve(dirname, 'fixtures/type-error.ts'), [
+        dts({
+          oxc: false,
+        }),
+      ]),
+    ).rejects.toThrow('error TS2322')
+  })
 })

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,9 @@ export function createDtsResolvePlugin({`
`84`	`84`	`const isRelativeOrAbsolute =`
`85`	`85`	`id.startsWith('.') \|\| path.isAbsolute(id)`
`86`	`86`	`if (isRelativeOrAbsolute) {`
`87`		- return this.error(`Cannot resolve import '${id}' from '${importer}'`)
	`87`	`+ return this.error(`
	`88`	+ `Cannot resolve import '${id}' from '${importer}'`,
	`89`	`+ )`
`88`	`90`	`}`
`89`	`91`	`return external`
`90`	`92`	`}`