fix(tsgo): skip cleanup in tsgo debug mode

sxzz · sxzz · commit c76f8ba09588 · 2026-06-04T20:23:38.000+09:00
diff --git a/src/generate.ts b/src/generate.ts
@@ -1,6 +1,6 @@
 import { fork, type ChildProcess } from 'node:child_process'
 import { existsSync } from 'node:fs'
-import { readFile, rm } from 'node:fs/promises'
+import { readFile } from 'node:fs/promises'
 import path from 'node:path'
 import { parse } from '@babel/parser'
 import { createDebug } from 'obug'
@@ -24,7 +24,7 @@ import {
   invalidateContextFile,
   type TscContext,
 } from './tsc/context.ts'
-import { runTsgo } from './tsgo.ts'
+import { runTsgo, type TsgoContext } from './tsgo.ts'
 import type { OptionsResolved } from './options.ts'
 import type { TscOptions, TscResult } from './tsc/index.ts'
 import type { TscFunctions } from './tsc/worker.ts'
@@ -106,15 +106,15 @@ export function createGeneratePlugin({
   let rpc: BirpcReturn<TscFunctions> | undefined
   let tscModule: typeof import('./tsc/index.ts')
   let tscContext: TscContext | undefined
-  let tsgoDist: string | undefined
+  let tsgoContext: TsgoContext | undefined
   const rootDir = tsconfig ? path.dirname(tsconfig) : cwd
 
   return {
     name: 'rolldown-plugin-dts:generate',
 
     async buildStart(options) {
       if (tsgo) {
-        tsgoDist = await runTsgo(rootDir, tsconfig, sourcemap, tsgo.path)
+        tsgoContext = await runTsgo(rootDir, tsconfig, sourcemap, tsgo.path)
       } else if (!oxc) {
         // tsc
         if (parallel) {
@@ -237,7 +237,7 @@ export function createGeneratePlugin({
           if (RE_VUE.test(id))
             throw new Error('tsgo does not support Vue files.')
           const dtsPath = path.resolve(
-            tsgoDist!,
+            tsgoContext!.path,
             path.relative(path.resolve(rootDir), filename_to_dts(id)),
           )
           if (!existsSync(dtsPath)) {
@@ -359,10 +359,8 @@ export { __json_default_export as default }`
 
     async buildEnd() {
       childProcess?.kill()
-      if (!debug.enabled && tsgoDist) {
-        await rm(tsgoDist, { recursive: true, force: true }).catch(() => {})
-      }
-      tsgoDist = undefined
+      await tsgoContext?.dispose()
+      tsgoContext = undefined
       if (newContext) {
         tscContext = undefined
       }
diff --git a/src/tsgo.ts b/src/tsgo.ts
@@ -1,5 +1,5 @@
 import { spawn } from 'node:child_process'
-import { mkdtemp } from 'node:fs/promises'
+import { mkdtemp, rm } from 'node:fs/promises'
 import { tmpdir } from 'node:os'
 import path from 'node:path'
 import { createDebug } from 'obug'
@@ -21,12 +21,17 @@ export async function getTsgoPathFromNodeModules(): Promise<string> {
   return getExePath()
 }
 
+export interface TsgoContext {
+  path: string
+  dispose: () => Promise<void>
+}
+
 export async function runTsgo(
   rootDir: string,
   tsconfig?: string,
   sourcemap?: boolean,
   tsgoPath?: string,
-): Promise<string> {
+): Promise<TsgoContext> {
   debug('[tsgo] rootDir', rootDir)
 
   let tsgo: string
@@ -57,5 +62,16 @@ export async function runTsgo(
   debug('[tsgo] args %o', args)
 
   await spawnAsync(tsgo, args, { stdio: 'inherit' })
-  return tsgoDist
+
+  return {
+    path: tsgoDist,
+    async dispose() {
+      if (debug.enabled) {
+        debug('[tsgo] skip cleanup of tsgoDist', tsgoDist)
+      } else {
+        debug('[tsgo] disposing tsgoDist', tsgoDist)
+        await rm(tsgoDist, { recursive: true, force: true }).catch(() => {})
+      }
+    },
+  }
 }
