feat!: remove resolve option, respect rolldown config

sxzz · sxzz · commit 0fa6905c8a79 · 2026-01-12T23:15:34.000+08:00
closes #106
diff --git a/README.md b/README.md
@@ -81,16 +81,6 @@ See: [TypeScript compilerOptions documentation](https://www.typescriptlang.org/t
 
 If `true`, the plugin will generate declaration maps (`.d.ts.map`) for `.d.ts` files.
 
-#### `resolve`
-
-Controls whether type definitions from `node_modules` are bundled into your final `.d.ts` file or kept as external `import` statements.
-
-By default, dependencies are external, resulting in `import { Type } from 'some-package'`. When bundled, this `import` is removed, and the type definitions from `some-package` are copied directly into your file.
-
-- `true`: Bundles all dependencies.
-- `false`: (Default) Keeps all dependencies external.
-- `(string | RegExp)[]`: Bundles only dependencies matching the provided strings or regular expressions (e.g. `['pkg-a', /^@scope\//]`).
-
 #### `resolver`
 
 Specifies a resolver to resolve type definitions, especially for `node_modules`.
diff --git a/src/options.ts b/src/options.ts
@@ -58,17 +58,6 @@ export interface GeneralOptions {
    */
   sourcemap?: boolean
 
-  /**
-   * Controls whether type definitions from `node_modules` are bundled into your final `.d.ts` file or kept as external `import` statements.
-   * 
-   * By default, dependencies are external, resulting in `import { Type } from 'some-package'`. When bundled, this `import` is removed, and the type definitions from `some-package` are copied directly into your file.
-
-   * - `true`: Bundles all dependencies.
-   * - `false`: (Default) Keeps all dependencies external.
-   * - `(string | RegExp)[]`: Bundles only dependencies matching the provided strings or regular expressions (e.g. `['pkg-a', /^@scope\//]`).
-   */
-  resolve?: boolean | (string | RegExp)[]
-
   /**
    * Specifies a resolver to resolve type definitions, especially for `node_modules`.
    *
@@ -231,7 +220,6 @@ export function resolveOptions({
   tsconfigRaw: overriddenTsconfigRaw = {},
   compilerOptions = {},
   sourcemap,
-  resolve = false,
   resolver = 'oxc',
   cjsDefault = false,
   sideEffects = false,
@@ -331,7 +319,6 @@ export function resolveOptions({
     tsconfig,
     tsconfigRaw,
     sourcemap,
-    resolve,
     resolver,
     cjsDefault,
     sideEffects,
diff --git a/src/resolver.ts b/src/resolver.ts
@@ -8,7 +8,6 @@ import {
   RE_CSS,
   RE_DTS,
   RE_JSON,
-  RE_NODE_MODULES,
   RE_TS,
   RE_VUE,
 } from './filename.ts'
@@ -25,16 +24,15 @@ export function createDtsResolvePlugin({
   cwd,
   tsconfig,
   tsconfigRaw,
-  resolve,
   resolver,
   sideEffects,
 }: Pick<
   OptionsResolved,
-  'cwd' | 'tsconfig' | 'tsconfigRaw' | 'resolve' | 'resolver' | 'sideEffects'
+  'cwd' | 'tsconfig' | 'tsconfigRaw' | 'resolver' | 'sideEffects'
 >): Plugin {
   const baseDtsResolver = createResolver({
     tsconfig,
-    resolveNodeModules: !!resolve,
+    resolveNodeModules: true,
     ResolverFactory,
   })
   const moduleSideEffects = sideEffects ? true : null
@@ -95,19 +93,6 @@ export function createDtsResolvePlugin({
           return isFileImport ? null : external
         }
 
-        // Externalize non-bundled node_modules dependencies
-        if (
-          // request resolved to inside node_modules
-          RE_NODE_MODULES.test(dtsResolution) &&
-          // User doesn't want to bundle this module
-          !shouldBundleNodeModule(id) &&
-          // The importer is not in node_modules, or if it is, the module is marked as external by Rolldown
-          !RE_NODE_MODULES.test(importer)
-        ) {
-          debug('Externalizing node_modules dts import:', id)
-          return external
-        }
-
         // The path is either a declaration file or a source file that needs redirection.
         if (RE_DTS.test(dtsResolution)) {
           debug('Resolving dts import to declaration file:', id)
@@ -132,13 +117,6 @@ export function createDtsResolvePlugin({
     },
   }
 
-  function shouldBundleNodeModule(id: string) {
-    if (typeof resolve === 'boolean') return resolve
-    return resolve.some((pattern) =>
-      typeof pattern === 'string' ? id === pattern : pattern.test(id),
-    )
-  }
-
   async function resolveDtsPath(
     id: string,
     importer: string,
diff --git a/tests/index.test.ts b/tests/index.test.ts
@@ -27,11 +27,11 @@ test('resolve dependencies', async () => {
     path.resolve(dirname, 'fixtures/resolve-dep.ts'),
     [
       dts({
-        resolve: ['get-tsconfig'],
         oxc: true,
         emitDtsOnly: true,
       }),
     ],
+    { external: ['rolldown'] },
   )
   expect(snapshot).contain('type TsConfigResult')
   expect(snapshot).not.contain('node_modules/rolldown')
diff --git a/tests/tsc.test.ts b/tests/tsc.test.ts
@@ -215,20 +215,25 @@ describe('tsc', () => {
 
   test('vue-sfc w/ ts-compiler w/ vueCompilerOptions in tsconfig', async () => {
     const root = path.resolve(dirname, 'fixtures/vue-sfc-fallthrough')
-    const { snapshot } = await rolldownBuild(path.resolve(root, 'main.ts'), [
-      dts({
-        tsconfig: path.resolve(root, 'tsconfig.json'),
-        emitDtsOnly: true,
-        vue: true,
-      }),
-    ])
+    const { snapshot } = await rolldownBuild(
+      path.resolve(root, 'main.ts'),
+      [
+        dts({
+          tsconfig: path.resolve(root, 'tsconfig.json'),
+          emitDtsOnly: true,
+          vue: true,
+        }),
+      ],
+      { external: ['vue'] },
+    )
     expect(snapshot).toMatchSnapshot()
   })
 
   test('jsdoc', async () => {
     const { snapshot } = await rolldownBuild(
       path.resolve(dirname, 'fixtures/jsdoc.ts'),
       [dts({ oxc: false })],
+      { external: ['rolldown'] },
     )
     expect(snapshot).toMatchSnapshot()
   })
@@ -258,14 +263,18 @@ describe('tsc', () => {
 
   test('vue-sfc w/ ts-macro w/ ts-compiler', async () => {
     const root = path.resolve(dirname, 'fixtures/vue-sfc-with-ts-macro')
-    const { snapshot } = await rolldownBuild(path.resolve(root, 'main.ts'), [
-      dts({
-        emitDtsOnly: true,
-        tsconfig: path.resolve(root, 'tsconfig.json'),
-        vue: true,
-        tsMacro: true,
-      }),
-    ])
+    const { snapshot } = await rolldownBuild(
+      path.resolve(root, 'main.ts'),
+      [
+        dts({
+          emitDtsOnly: true,
+          tsconfig: path.resolve(root, 'tsconfig.json'),
+          vue: true,
+          tsMacro: true,
+        }),
+      ],
+      { external: ['vue'] },
+    )
     expect(snapshot).toMatchSnapshot()
   })
 
@@ -280,6 +289,7 @@ describe('tsc', () => {
           emitDtsOnly: true,
         }),
       ],
+      { external: [/^arktype/] },
     )
     expect(snapshot).toMatchSnapshot()
   })

Original file line number	Diff line number	Diff line change
`@@ -27,11 +27,11 @@ test('resolve dependencies', async () => {`
`27`	`27`	`path.resolve(dirname, 'fixtures/resolve-dep.ts'),`
`28`	`28`	`[`
`29`	`29`	`dts({`
`30`		`- resolve: ['get-tsconfig'],`
`31`	`30`	`oxc: true,`
`32`	`31`	`emitDtsOnly: true,`
`33`	`32`	`}),`
`34`	`33`	`],`
	`34`	`+ { external: ['rolldown'] },`
`35`	`35`	`)`
`36`	`36`	`expect(snapshot).contain('type TsConfigResult')`
`37`	`37`	`expect(snapshot).not.contain('node_modules/rolldown')`