Skip to content

Parse integer generics#2859

Merged
ahoppen merged 10 commits intoswiftlang:mainfrom
Azoy:integer-types
Nov 7, 2024
Merged

Parse integer generics#2859
ahoppen merged 10 commits intoswiftlang:mainfrom
Azoy:integer-types

Conversation

@Azoy
Copy link
Copy Markdown
Contributor

@Azoy Azoy commented Sep 24, 2024

No description provided.

ahoppen
ahoppen reviewed Sep 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this, @Azoy!

@Azoy Azoy requested a review from ahoppen October 17, 2024 17:19
@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Oct 17, 2024

@swift-ci please test

ahoppen
ahoppen approved these changes Oct 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me 👍🏽

@Azoy Azoy changed the title Introduce genericArgumentType and parse integer generics Parse integer generics Oct 21, 2024
@Azoy Azoy mentioned this pull request Oct 21, 2024
Merged
@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Oct 21, 2024

Please test with following pull request:
swiftlang/swift#77149

@swift-ci please test

4 similar comments
@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Oct 21, 2024

Please test with following pull request:
swiftlang/swift#77149

@swift-ci please test

@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Oct 22, 2024

Please test with following pull request:
swiftlang/swift#77149

@swift-ci please test

@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Oct 22, 2024

Please test with following pull request:
swiftlang/swift#77149

@swift-ci please test

@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Oct 22, 2024

Please test with following pull request:
swiftlang/swift#77149

@swift-ci please test

@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Oct 24, 2024

Please test with following pull request:
swiftlang/swift#77149

@swift-ci please test

@ahoppen
Copy link
Copy Markdown
Member

ahoppen commented Oct 24, 2024

swiftlang/swift#77149

@swift-ci please test Windows

ahoppen
ahoppen approved these changes Oct 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the issue @Azoy

@Azoy Azoy mentioned this pull request Oct 25, 2024
Merged
@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Oct 25, 2024

Please test with following pull request:
swiftlang/swift#77149
swiftlang/swift-format#866

@swift-ci please test

@ahoppen ahoppen mentioned this pull request Oct 25, 2024
Merged
@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Oct 28, 2024

Please test with following pull request:
swiftlang/swift#77149
swiftlang/swift-format#866

@swift-ci please test

1 similar comment
@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Oct 28, 2024

Please test with following pull request:
swiftlang/swift#77149
swiftlang/swift-format#866

@swift-ci please test

ahoppen added a commit to ahoppen/github-workflows that referenced this pull request Oct 29, 2024
@ahoppen
Support cross-PR testing for Swift packages
477c131 
This allows Swift Packages to be tested in combination with PRs updating their dependencies. To reference a linked PR, `Linked PR: <link to PR>` needs to be added to the PR description, eg:

```
Linked PR: swiftlang/swift-syntax#2859
```
ahoppen added a commit to ahoppen/github-workflows that referenced this pull request Oct 29, 2024
@ahoppen
Support cross-PR testing for Swift packages
6e119b1 
This allows Swift Packages to be tested in combination with PRs updating their dependencies. To reference a linked PR, `Linked PR: <link to PR>` needs to be added to the PR description, eg:

```
Linked PR: swiftlang/swift-syntax#2859
```
ahoppen added a commit to ahoppen/github-workflows that referenced this pull request Oct 29, 2024
@ahoppen
Support cross-PR testing for Swift packages
9c5ec1e 
This allows Swift Packages to be tested in combination with PRs updating their dependencies. To reference a linked PR, `Linked PR: <link to PR>` needs to be added to the PR description, eg:

```
Linked PR: swiftlang/swift-syntax#2859
```
ahoppen added a commit to ahoppen/github-workflows that referenced this pull request Oct 29, 2024
@ahoppen
Support cross-PR testing for Swift packages
18a8878 
This allows Swift Packages to be tested in combination with PRs updating their dependencies. To reference a linked PR, `Linked PR: <link to PR>` needs to be added to the PR description, eg:

```
Linked PR: swiftlang/swift-syntax#2859
```
ahoppen added a commit to ahoppen/github-workflows that referenced this pull request Oct 29, 2024
@ahoppen
Support cross-PR testing for Swift packages
bd3f008 
This allows Swift Packages to be tested in combination with PRs updating their dependencies. To reference a linked PR, `Linked PR: <link to PR>` needs to be added to the PR description, eg:

```
Linked PR: swiftlang/swift-syntax#2859
```
ahoppen added a commit to ahoppen/github-workflows that referenced this pull request Oct 29, 2024
@ahoppen
Support cross-PR testing for Swift packages
aded4b8 
This allows Swift Packages to be tested in combination with PRs updating their dependencies. To reference a linked PR, `Linked PR: <link to PR>` needs to be added to the PR description, eg:

```
Linked PR: swiftlang/swift-syntax#2859
```
@ahoppen ahoppen mentioned this pull request Oct 29, 2024
Merged
@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Nov 4, 2024

Please test with following pull request:
swiftlang/swift#77149
swiftlang/swift-format#866

@swift-ci please test

1 similar comment
@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Nov 5, 2024

Please test with following pull request:
swiftlang/swift#77149
swiftlang/swift-format#866

@swift-ci please test

@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Nov 5, 2024

Please test with following pull request:
swiftlang/swift#77149
swiftlang/swift-format#866

@swift-ci please test

@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Nov 5, 2024

Please test with following pull request:
swiftlang/swift#77149
swiftlang/swift-format#866

@swift-ci please test Windows

1 similar comment
@Azoy
Copy link
Copy Markdown
Contributor Author

Azoy commented Nov 6, 2024

Please test with following pull request:
swiftlang/swift#77149
swiftlang/swift-format#866

@swift-ci please test Windows

@ahoppen ahoppen merged commit 38459d4 into swiftlang:main Nov 7, 2024
@Azoy Azoy deleted the integer-types branch November 7, 2024 22:11
ahoppen added a commit to ahoppen/github-workflows that referenced this pull request Nov 8, 2024
@ahoppen
Support cross-PR testing for Swift packages
54b9441 
This allows Swift Packages to be tested in combination with PRs updating their dependencies. To reference a linked PR, `Linked PR: <link to PR>` needs to be added to the PR description, eg:

```
Linked PR: swiftlang/swift-syntax#2859
```
@ahoppen ahoppen mentioned this pull request Nov 12, 2024
Merged
This was referenced Dec 16, 2024
Merged
Merged
ahoppen added a commit to ahoppen/github-workflows that referenced this pull request Mar 28, 2025
@ahoppen
Support cross-PR testing for Swift packages
52d4a0a 
This allows Swift Packages to be tested in combination with PRs updating their dependencies. To reference a linked PR, `Linked PR: <link to PR>` needs to be added to the PR description, eg:

```
Linked PR: swiftlang/swift-syntax#2859
```
@scottrhoyt scottrhoyt mentioned this pull request Jun 11, 2025
Closed
@Kolos65 Kolos65 mentioned this pull request Jun 11, 2025
Merged
ahoppen added a commit to ahoppen/github-workflows that referenced this pull request Aug 4, 2025
@ahoppen
Support cross-PR testing for Swift packages
9570ff6 
This allows Swift Packages to be tested in combination with PRs updating their dependencies. To reference a linked PR, `Linked PR: <link to PR>` needs to be added to the PR description, eg:

```
Linked PR: swiftlang/swift-syntax#2859
```
ahoppen added a commit to swiftlang/github-workflows that referenced this pull request Sep 1, 2025
@ahoppen
Support cross-PR testing for Swift packages (#52)
f1b992b 
This allows Swift Packages to be tested in combination with PRs updating their dependencies. To reference a linked PR, `Linked PR: <link to PR>` needs to be added to the PR description, eg:

```
Linked PR: swiftlang/swift-syntax#2859
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahoppen ahoppen ahoppen approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Azoy @ahoppen