Skip to content

fix(es/minifier): Remove optimization for array pattern#9241

Merged
kdy1 merged 3 commits intoswc-project:mainfrom
CPunisher:fix/array-pat-opt
Jul 15, 2024
Merged

fix(es/minifier): Remove optimization for array pattern#9241
kdy1 merged 3 commits intoswc-project:mainfrom
CPunisher:fix/array-pat-opt

Conversation

@CPunisher
Copy link
Copy Markdown
Member

@CPunisher CPunisher commented Jul 15, 2024

Description:

This could be an unsound optimization. The issue shows a bad case.

Related issue:

@CPunisher CPunisher requested a review from a team as a code owner July 15, 2024 05:47
@CPunisher
Copy link
Copy Markdown
Member Author

or marked as unsafe

Copy link
Copy Markdown
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_optimization
  • swc_core

@kdy1 kdy1 added this to the Planned milestone Jul 15, 2024
@kdy1 kdy1 enabled auto-merge (squash) July 15, 2024 06:19
@kdy1 kdy1 disabled auto-merge July 15, 2024 06:19
@kdy1 kdy1 enabled auto-merge (squash) July 15, 2024 06:19
@kdy1 kdy1 changed the title fix(es/optimization): Remove optimization for array pattern fix(es/minifier): Remove optimization for array pattern Jul 15, 2024
@kdy1 kdy1 disabled auto-merge July 15, 2024 06:22
@kdy1 kdy1 enabled auto-merge (squash) July 15, 2024 06:25
Copy link
Copy Markdown
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 521161e into swc-project:main Jul 15, 2024
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 15, 2024

CodSpeed Performance Report

Merging #9241 will not alter performance

Comparing CPunisher:fix/array-pat-opt (e359fd3) with CPunisher:fix/array-pat-opt (0d5c575)

Summary

✅ 178 untouched benchmarks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Minifier removes empty array following empty hole at the LHS of array destructuring pattern

3 participants