Skip to content

fix(es/fixer): Wrap object tagged templates#9991

Merged
kdy1 merged 3 commits intoswc-project:mainfrom
magic-akari:fix/issue-9930
Feb 5, 2025
Merged

fix(es/fixer): Wrap object tagged templates#9991
kdy1 merged 3 commits intoswc-project:mainfrom
magic-akari:fix/issue-9930

Conversation

@magic-akari
Copy link
Copy Markdown
Member

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: 443f676

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 added this to the Planned milestone Feb 5, 2025
@magic-akari magic-akari marked this pull request as ready for review February 5, 2025 03:54
@magic-akari magic-akari requested a review from a team as a code owner February 5, 2025 03:54
@kdy1 kdy1 requested a review from a team as a code owner February 5, 2025 04:09
Copy link
Copy Markdown
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 enabled auto-merge (squash) February 5, 2025 04:09
@kdy1 kdy1 merged commit 963c3a5 into swc-project:main Feb 5, 2025
@magic-akari magic-akari deleted the fix/issue-9930 branch February 5, 2025 05:21
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #9991 will degrade performances by 6.76%

Comparing magic-akari:fix/issue-9930 (443f676) with main (9c89d57)

Summary

❌ 3 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/moment 119.4 ms 128.1 ms -6.76%
es/lints/libs/react 1.7 ms 1.7 ms -4.68%
es/minifier/libs/jquery 156.3 ms 164.2 ms -4.82%

@kdy1 kdy1 modified the milestones: Planned, v1.10.15 Feb 8, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

minifier: Removing parentheses around objects and tagged templates causes syntax errors

2 participants