Skip to content

refactor(hstr): Remove needless operations#9964

Merged
kdy1 merged 2 commits intoswc-project:mainfrom
kdy1:small-1
Jan 26, 2025
Merged

refactor(hstr): Remove needless operations#9964
kdy1 merged 2 commits intoswc-project:mainfrom
kdy1:small-1

Conversation

@kdy1
Copy link
Copy Markdown
Member

@kdy1 kdy1 commented Jan 26, 2025 •
edited
Loading

Description:

We don't have an atom store merging API, so we don't need this code.

@kdy1 kdy1 added this to the Planned milestone Jan 26, 2025
@kdy1 kdy1 self-assigned this Jan 26, 2025
@kdy1 kdy1 requested a review from a team as a code owner January 26, 2025 20:09
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 26, 2025

⚠️ No Changeset found

Latest commit: 2f7f071

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 enabled auto-merge (squash) January 26, 2025 20:10
@kdy1 kdy1 disabled auto-merge January 26, 2025 20:33
@kdy1 kdy1 merged commit 6f781d8 into swc-project:main Jan 26, 2025
@kdy1 kdy1 deleted the small-1 branch January 26, 2025 20:33
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 26, 2025

CodSpeed Performance Report

Merging #9964 will degrade performances by 3.24%

Comparing kdy1:small-1 (2f7f071) with main (bc61c13)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ es/lints/libs/victory 105.2 ms 99.4 ms +5.86%
⚡ es/minifier/libs/moment 107.7 ms 99.6 ms +8.19%
❌ es/minifier/libs/vue 240.1 ms 248.1 ms -3.24%

@kdy1 kdy1 modified the milestones: Planned, v1.10.10 Jan 27, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels

None yet

Milestone

v1.10.10

Development

Successfully merging this pull request may close these issues.

1 participant

@kdy1