Skip to content

perf(es/minifier): Cache var_or_default calls#9909

Merged
kdy1 merged 2 commits intoswc-project:mainfrom
kdy1:min-2
Jan 21, 2025
Merged

perf(es/minifier): Cache var_or_default calls#9909
kdy1 merged 2 commits intoswc-project:mainfrom
kdy1:min-2

Conversation

@kdy1
Copy link
Copy Markdown
Member

@kdy1 kdy1 commented Jan 21, 2025

Description:

This is a simple fix to ensure that we hash the Id only once.

@kdy1 kdy1 added this to the Planned milestone Jan 21, 2025
@kdy1 kdy1 requested a review from a team as a code owner January 21, 2025 10:43
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 56e39e9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq Bot previously approved these changes Jan 21, 2025
@kdy1 kdy1 requested a review from a team as a code owner January 21, 2025 10:43
@kdy1 kdy1 enabled auto-merge (squash) January 21, 2025 10:44
@kdy1 kdy1 disabled auto-merge January 21, 2025 10:48
@kdy1 kdy1 merged commit 4a3be8d into swc-project:main Jan 21, 2025
@kdy1 kdy1 deleted the min-2 branch January 21, 2025 10:48
kdy1 added a commit that referenced this pull request Jan 21, 2025
**Description:**

Previous PR may decrease the performance if the result of `collect_infects_to` is empty.

**Related issue:**

 - Inverts #9909
@kdy1 kdy1 modified the milestones: Planned, v1.10.9 Jan 21, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 21, 2025

CodSpeed Performance Report

Merging #9909 will not alter performance

Comparing kdy1:min-2 (56e39e9) with main (ce22557)

Summary

✅ 196 untouched benchmarks

@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant