Skip to content

fix(es/minifier): Fix case matching#9208

Merged
kdy1 merged 3 commits intoswc-project:mainfrom
CPunisher:fix/invalid-case-matching
Jul 11, 2024
Merged

fix(es/minifier): Fix case matching#9208
kdy1 merged 3 commits intoswc-project:mainfrom
CPunisher:fix/invalid-case-matching

Conversation

@CPunisher
Copy link
Copy Markdown
Member

@CPunisher CPunisher commented Jul 11, 2024

Description:

Caused by #7112
Since swc minifier evaluates expressions in a separate pass, I make a temporary patch here.

Related issue:

@CPunisher CPunisher requested a review from a team as a code owner July 11, 2024 12:08
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 11, 2024

CodSpeed Performance Report

Merging #9208 will degrade performances by 31.99%

Comparing CPunisher:fix/invalid-case-matching (e315725) with CPunisher:fix/invalid-case-matching (cb203c9)

Summary

❌ 1 regressions
✅ 173 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark CPunisher:fix/invalid-case-matching CPunisher:fix/invalid-case-matching Change
es/full/base/resolver_and_hygiene 328.9 µs 483.6 µs -31.99%

Copy link
Copy Markdown
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


swc-bump:

  • swc_ecma_minifier
  • swc_core

@kdy1 kdy1 changed the title fix(es/minifier): invalid case matching fix(es/minifier): Fix case matching Jul 11, 2024
@kdy1 kdy1 enabled auto-merge (squash) July 11, 2024 14:01
Copy link
Copy Markdown
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit f81fa6e into swc-project:main Jul 11, 2024
@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 14, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

minifier: invalid case matching in switch statement

3 participants