Skip to content

feat(preset-env): Upgrade browserslist-rs#9023

Merged
kdy1 merged 9 commits intoswc-project:mainfrom
g-plane:upgrade-browserslist
Jul 1, 2024
Merged

feat(preset-env): Upgrade browserslist-rs#9023
kdy1 merged 9 commits intoswc-project:mainfrom
g-plane:upgrade-browserslist

Conversation

@g-plane
Copy link
Copy Markdown
Contributor

@g-plane g-plane commented Jun 5, 2024

Description:

Compilation time of browserslist-rs has beed reduced by 32%. See: browserslist/browserslist-rs#23

But, it's still slower that oxc-browserslist:

image

while browserslist-rs costs about 3.9s.

BREAKING CHANGE:

Related issue (if exists):

Close #9014

@g-plane g-plane requested a review from a team as a code owner June 5, 2024 10:31
@CPatchane CPatchane mentioned this pull request Jun 25, 2024
Closed
@chenjiahan
Copy link
Copy Markdown
Contributor

chenjiahan commented Jun 25, 2024

The CI is failed, can you take a look? ❤️

@g-plane
Copy link
Copy Markdown
Contributor Author

g-plane commented Jun 25, 2024

I failed to fix it. Let's ask help to @kdy1 .

kdy1
kdy1 previously approved these changes Jul 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • preset_env_base --breaking

@kdy1 kdy1 added this to the Planned milestone Jul 1, 2024
@kdy1 kdy1 self-assigned this Jul 1, 2024
@kdy1 kdy1 requested review from a team as code owners July 1, 2024 04:37
kdy1
kdy1 previously approved these changes Jul 1, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) July 1, 2024 04:38
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Jul 1, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/escape-html@1.0.3 None 0 3.66 kB dougwilson

🚮 Removed packages: npm/@babel/compat-data@7.23.2, npm/escalade@3.1.1

View full report↗︎

@kdy1 kdy1 merged commit 18d6277 into swc-project:main Jul 1, 2024
@kdy1
Copy link
Copy Markdown
Member

kdy1 commented Jul 1, 2024 •
edited
Loading

  • cd crates/swc && time cargo build --release --features swc_ecma_minifier/concurrent

Before this PR:

    Finished `release` profile [optimized] target(s) in 37.52s
cargo build --release --features swc_ecma_minifier/concurrent  365.78s user 11.74s system 1004% cpu 37.592 total

After this PR:

    Finished `release` profile [optimized] target(s) in 38.98s
cargo build --release --features swc_ecma_minifier/concurrent  355.72s user 10.34s system 937% cpu 39.048 total

@g-plane
Copy link
Copy Markdown
Contributor Author

g-plane commented Jul 1, 2024

Does it look slower? That's weird.

@kdy1
Copy link
Copy Markdown
Member

kdy1 commented Jul 1, 2024

I think it's a noise

@kdy1 kdy1 mentioned this pull request Jul 2, 2024
Merged
@kdy1 kdy1 removed this from the Planned milestone Jul 3, 2024
@kdy1 kdy1 added this to the v1.6.7 milestone Jul 3, 2024
@chenjiahan chenjiahan mentioned this pull request Jul 14, 2024
Merged
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels

None yet

Milestone

v1.6.7

Development

Successfully merging this pull request may close these issues.

3 participants

@g-plane @chenjiahan @kdy1