Skip to content

fix(es/proposal): Preserve class id for hoisted classes when transforming using declarations#10407

Merged
kdy1 merged 5 commits intoswc-project:mainfrom
magic-akari:fix/explicit-resource-management
Apr 26, 2025
Merged

fix(es/proposal): Preserve class id for hoisted classes when transforming using declarations#10407
kdy1 merged 5 commits intoswc-project:mainfrom
magic-akari:fix/explicit-resource-management

Conversation

@magic-akari
Copy link
Copy Markdown
Member

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 25, 2025

🦋 Changeset detected

Latest commit: 46976d2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 25, 2025

CodSpeed Performance Report

Merging #10407 will not alter performance

Comparing magic-akari:fix/explicit-resource-management (46976d2) with main (b703f21)

Summary

✅ 45 untouched benchmarks
🆕 107 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 es/lints/libs/antd N/A 200 ms N/A
🆕 es/lints/libs/d3 N/A 28.3 ms N/A
🆕 es/lints/libs/echarts N/A 146.2 ms N/A
🆕 es/lints/libs/jquery N/A 7.5 ms N/A
🆕 es/lints/libs/lodash N/A 7.1 ms N/A
🆕 es/lints/libs/moment N/A 4.8 ms N/A
🆕 es/lints/libs/react N/A 1.5 ms N/A
🆕 es/lints/libs/terser N/A 29.5 ms N/A
🆕 es/lints/libs/three N/A 64.1 ms N/A
🆕 es/lints/libs/typescript N/A 354.3 ms N/A
🆕 es/lints/libs/victory N/A 90.6 ms N/A
🆕 es/lints/libs/vue N/A 9.5 ms N/A
🆕 es/minifier/libs/antd N/A 2.5 s N/A
🆕 es/minifier/libs/d3 N/A 448.9 ms N/A
🆕 es/minifier/libs/echarts N/A 1.7 s N/A
🆕 es/minifier/libs/jquery N/A 113 ms N/A
🆕 es/minifier/libs/lodash N/A 134.1 ms N/A
🆕 es/minifier/libs/moment N/A 72.4 ms N/A
🆕 es/minifier/libs/react N/A 23 ms N/A
🆕 es/minifier/libs/terser N/A 393.4 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@magic-akari magic-akari changed the title fix(es/proposal): Preserve class id when transforming using declarations with exported class fix(es/proposal): Preserve class id for hoisted classes when transforming using declarations Apr 25, 2025
@magic-akari magic-akari marked this pull request as ready for review April 25, 2025 15:58
@magic-akari magic-akari requested a review from a team as a code owner April 25, 2025 15:58
@kdy1 kdy1 added this to the Planned milestone Apr 25, 2025
@kdy1 kdy1 self-assigned this Apr 25, 2025
kdy1
kdy1 previously approved these changes Apr 26, 2025
@kdy1 kdy1 requested a review from a team as a code owner April 26, 2025 03:13
@kdy1 kdy1 merged commit b703f21 into swc-project:main Apr 26, 2025
18 checks passed
@magic-akari magic-akari deleted the fix/explicit-resource-management branch April 29, 2025 03:32
@kdy1 kdy1 modified the milestones: Planned, v1.11.23 Apr 29, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants