Skip to content

perf(es/lexer): Optimize whitespace scanning#10136

Merged
kdy1 merged 2 commits intomainfrom
kdy1/lexer-ws
Mar 5, 2025
Merged

perf(es/lexer): Optimize whitespace scanning#10136
kdy1 merged 2 commits intomainfrom
kdy1/lexer-ws

Conversation

@kdy1
Copy link
Copy Markdown
Member

@kdy1 kdy1 commented Mar 4, 2025

Description:

BREAKING CHANGE:

Related issue (if exists):

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 4, 2025

⚠️ No Changeset found

Latest commit: c736fd5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 4, 2025

CodSpeed Performance Report

Merging #10136 will degrade performances by 4.98%

Comparing kdy1/lexer-ws (c736fd5) with main (740bd57)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 189 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/moment 104.3 ms 109.7 ms -4.98%
es/lexer/yui 8.1 ms 7.9 ms +3.2%

@kdy1 kdy1 marked this pull request as ready for review March 5, 2025 03:27
@kdy1 kdy1 requested a review from a team as a code owner March 5, 2025 03:27
@kdy1 kdy1 merged commit 8a59753 into main Mar 5, 2025
Copy link
Copy Markdown
Member Author

kdy1 commented Mar 5, 2025

Merge activity

  • Mar 5, 12:58 PM GMT+9: A user merged this pull request with Graphite.

@kdy1 kdy1 deleted the kdy1/lexer-ws branch March 5, 2025 03:58
@kdy1 kdy1 modified the milestones: Planned, v1.11.7 Mar 6, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant