Skip to content

fix(es/minifier): Fix regression due to #10056#10134

Merged
kdy1 merged 7 commits intomainfrom
kdy1/10133
Mar 4, 2025
Merged

fix(es/minifier): Fix regression due to #10056#10134
kdy1 merged 7 commits intomainfrom
kdy1/10133

Conversation

@kdy1
Copy link
Copy Markdown
Member

@kdy1 kdy1 commented Mar 4, 2025

Description:

Related issue:

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: 0d6a8fc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1
Copy link
Copy Markdown
Member Author

kdy1 commented Mar 4, 2025

❯ git bisect bad
19d01d718aeb7a211384944dd2d9858cc4f04da2 is the first bad commit
commit 19d01d718aeb7a211384944dd2d9858cc4f04da2
Date:   Thu Feb 20 23:44:38 2025 +0800

    feat(es/minifier): Inline across side-effect-free member exprs, (#10056)

    **Description:**

    This is safe even in the presence of an impure setter because JS eval rhs **before** setter

    ```js
    ({ set a(v) { console.log(v) }}).a = (console.log(1), 2)
    ```

    would output `1 2`, and gcc has this optimization too.
``

@kdy1 kdy1 changed the title fix(es/minifier): Fix regression fix(es/minifier): Fix regression due to #10056 Mar 4, 2025
@kdy1 kdy1 marked this pull request as ready for review March 4, 2025 05:32
@kdy1 kdy1 requested review from a team as code owners March 4, 2025 05:32
@kdy1 kdy1 enabled auto-merge (squash) March 4, 2025 05:32
@kdy1 kdy1 added this to the Planned milestone Mar 4, 2025
@kdy1 kdy1 disabled auto-merge March 4, 2025 05:41
@kdy1 kdy1 merged commit b145275 into main Mar 4, 2025
@kdy1 kdy1 deleted the kdy1/10133 branch March 4, 2025 05:41
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 4, 2025

CodSpeed Performance Report

Merging #10134 will degrade performances by 3.78%

Comparing kdy1/10133 (02e91bc) with main (7bea830)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 188 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/lodash 189.7 ms 182.5 ms +3.95%
es/minifier/libs/jquery 128.1 ms 132.8 ms -3.5%
es/minifier/libs/lodash 149.1 ms 154.9 ms -3.78%

@kdy1 kdy1 modified the milestones: Planned, v1.11.6 Mar 4, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

v1.11 breaks ordering with inlined functions

1 participant