Skip to content

perf(es/minifier): Make the default pass 2#10014

Merged
kdy1 merged 3 commits intoswc-project:mainfrom
kdy1:min-pass-2
Feb 8, 2025
Merged

perf(es/minifier): Make the default pass 2#10014
kdy1 merged 3 commits intoswc-project:mainfrom
kdy1:min-pass-2

Conversation

@kdy1
Copy link
Copy Markdown
Member

@kdy1 kdy1 commented Feb 8, 2025

Description:

2 seems to be a better default according to the data of real world apps

@kdy1 kdy1 self-assigned this Feb 8, 2025
@kdy1 kdy1 requested a review from a team as a code owner February 8, 2025 03:01
@kdy1 kdy1 added this to the Planned milestone Feb 8, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 8, 2025

🦋 Changeset detected

Latest commit: 87e4cba

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq Bot previously approved these changes Feb 8, 2025
kodiakhq[bot]
kodiakhq Bot previously approved these changes Feb 8, 2025
@kdy1 kdy1 requested a review from a team as a code owner February 8, 2025 03:02
@kdy1 kdy1 enabled auto-merge (squash) February 8, 2025 03:03
@kdy1 kdy1 disabled auto-merge February 8, 2025 03:06
@kdy1 kdy1 enabled auto-merge (squash) February 8, 2025 03:07
@kdy1 kdy1 disabled auto-merge February 8, 2025 03:12
@kdy1 kdy1 merged commit 07dc423 into swc-project:main Feb 8, 2025
@kdy1 kdy1 deleted the min-pass-2 branch February 8, 2025 03:13
@kdy1 kdy1 modified the milestones: Planned, v1.10.15 Feb 8, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 8, 2025

CodSpeed Performance Report

Merging #10014 will improve performances by 28.18%

Comparing kdy1:min-pass-2 (87e4cba) with main (6849b6a)

Summary

⚡ 24 improvements
✅ 172 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/antd 3.8 s 3.3 s +14.22%
es/full/minify/libraries/d3 746.4 ms 606.6 ms +23.05%
es/full/minify/libraries/echarts 2.9 s 2.4 s +22.63%
es/full/minify/libraries/jquery 194.4 ms 169.4 ms +14.76%
es/full/minify/libraries/lodash 217.6 ms 179.1 ms +21.48%
es/full/minify/libraries/moment 119 ms 106.1 ms +12.16%
es/full/minify/libraries/react 35.6 ms 30.1 ms +18.22%
es/full/minify/libraries/terser 581.6 ms 503 ms +15.64%
es/full/minify/libraries/three 1,161.5 ms 998.8 ms +16.29%
es/full/minify/libraries/typescript 6.2 s 5.2 s +19.6%
es/full/minify/libraries/victory 1.7 s 1.4 s +20.71%
es/full/minify/libraries/vue 268.8 ms 224.8 ms +19.57%
es/minifier/libs/antd 3.2 s 2.7 s +15.98%
es/minifier/libs/d3 627.4 ms 489.5 ms +28.18%
es/minifier/libs/echarts 2.4 s 1.9 s +24.09%
es/minifier/libs/jquery 163.4 ms 136.5 ms +19.71%
es/minifier/libs/lodash 180 ms 145.2 ms +23.99%
es/minifier/libs/moment 103.3 ms 82.2 ms +25.59%
es/minifier/libs/react 29.9 ms 24.7 ms +21.05%
es/minifier/libs/terser 466 ms 395.8 ms +17.73%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant