Skip to content

perf(es/minifier): Do not clone from take_ident_of_pat_if_unused#10005

Merged
kdy1 merged 2 commits intoswc-project:mainfrom
kdy1:issue-9999
Feb 6, 2025
Merged

perf(es/minifier): Do not clone from take_ident_of_pat_if_unused#10005
kdy1 merged 2 commits intoswc-project:mainfrom
kdy1:issue-9999

Conversation

@kdy1
Copy link
Copy Markdown
Member

@kdy1 kdy1 commented Feb 6, 2025

@kdy1 kdy1 added this to the Planned milestone Feb 6, 2025
@kdy1 kdy1 self-assigned this Feb 6, 2025
@kdy1 kdy1 requested a review from a team as a code owner February 6, 2025 17:42
kodiakhq[bot]
kodiakhq Bot previously approved these changes Feb 6, 2025
View reviewed changes
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 6, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c186bf0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 enabled auto-merge (squash) February 6, 2025 17:42
@kdy1 kdy1 requested a review from a team as a code owner February 6, 2025 17:43
@kdy1 kdy1 merged commit dc3b46e into swc-project:main Feb 6, 2025
@kdy1 kdy1 deleted the issue-9999 branch February 6, 2025 18:16
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10005 will degrade performances by 5.13%

Comparing kdy1:issue-9999 (c186bf0) with main (6f4e7ad)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 194 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ es/minifier/libs/lodash 197.7 ms 208.4 ms -5.13%
⚡ es/minifier/libs/moment 105.1 ms 102 ms +3.06%

@kdy1 kdy1 modified the milestones: Planned, v1.10.15 Feb 8, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels

None yet

Milestone

v1.10.15

Development

Successfully merging this pull request may close these issues.

es/minifier: take_ident_of_pat_if_unused should not clone Box<VarUsageInfo>

1 participant

@kdy1