chore: Update @types/csso and correct types#1910
Merged
Conversation
Follow upstream commit: DefinitelyTyped/DefinitelyTyped@394c175 Can remove the ts-ignore when importing specificity. The specificity function return a 3-tuple, so update the type alias in lib/types.d.ts.
Member
|
Thanks for the fix! I was looking into making a similar pull request a few weeks ago, but shelved it as DefinitelyTyped doesn't accept types for internal APIs, which the
Might be that I was wrong and it's meant to be public, but in any case, happy to run with this now that it's defined in the types. 🎉 Btw, I rebased your changes to make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow upstream commit:
DefinitelyTyped/DefinitelyTyped@394c175
Can remove the ts-ignore when importing specificity.
The specificity function return a 3-tuple, so update the type alias in lib/types.d.ts.