fix: reject pending async deriveds on discard#18308
Merged
Merged
Conversation
The rejects all async deriveds of a batch as `OBSOLETE`, so they don't hang around and bail early without triggering the batch. If we don't do this, an async derived can trigger the already done batch, which schedules an effect that is never flushed. Because it is never flushed the branches it touched on its way up are never cleared, and so anything else in that subtree is now unreactive.
🦋 Changeset detectedLatest commit: 61b8208 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Member
|
looks like this causes a lot of legit test failures |
Member
Author
|
This feels like another one of those "the fix is correct and revealed other bugs" cases. One of the failures (maybe all of them are similar) is around |
Member
Author
|
Tests should all be passing now (if github CI ever runs). This PR revealed one bug and the fix needed one adjustment:
|
Rich-Harris
approved these changes
Jun 1, 2026
Merged
dummdidumm
pushed a commit
that referenced
this pull request
Jun 4, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.56.2 ### Patch Changes - fix: properly track effect end node for async sibling component ([#18371](#18371)) - fix: prevent false-positive reactivity loss warning ([#18373](#18373)) - chore: bump esrap dependency ([#18372](#18372)) - fix: ignore declaration tags for animation directive ([#18366](#18366)) - fix: reject pending async deriveds on discard ([#18308](#18308)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rejects all async deriveds of a batch as
OBSOLETE, so they don't hang around and bail early without triggering the batch.If we don't do this, an async derived can trigger the already done batch, which schedules an effect that is never flushed. Because it is never flushed the branches it touched on its way up are never cleared, and so anything else in that subtree is now unreactive.